Add span and metric instrumentation to the LS metrics SDK export #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #590 +/- ##
==========================================
+ Coverage 89.55% 89.58% +0.02%
==========================================
Files 62 62
Lines 3629 3658 +29
==========================================
+ Hits 3250 3277 +27
Misses 286 286
- Partials 93 95 +2 ☔ View full report in Codecov by Sentry. |
moh-osman3
approved these changes
Dec 20, 2023
jmacd
added a commit
that referenced
this pull request
Jan 4, 2024
**Description:** Follows similar work from #590 on the metrics exporter released in 1.23. This will create a span covering the export, not metrics (for reasons explained within). Pipelines: the trace SDK was still using the otel-go trace exporter, while the otelcol-based trace exporter here was still experimental. Lightstep has been using this exporter internally since its original release, and now considers it production ready. This switches the pipelines to always use the new exporter. Fixes a typo: the MaxInFlightSizeMiB setting was set too large by a factor of 1Mi in two places. **Testing:** Manual. The `examples/traces` function has to be modified to block in order to see the new span come through, since the span called during shut down will never export. I added `select{}` to the end of that main and checked the span came through.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Adds a span and a metric about the outcome of the LS metrics SDK periodic exporter. Changes the default to enable spans about the metrics SDK export. We will consider doing this for the span exporter, but it's different in that case because of the processor. Metrics SDKs don't drop, so we keep it simple in this PR w/ only metrics support.
Link to tracking Issue: Internal: LS-56746
Testing: Manual testing. Also:
go work syncbecause otel deps were out of date w/ respect to OTel-Arrow.Documentation: None. Self-tracing/metricing is not documented, happens as a result of the otelcol export pipeline using the globals.