Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add measurement processor support #493

Merged
merged 5 commits into from
Jun 27, 2023
Merged

Add measurement processor support #493

merged 5 commits into from
Jun 27, 2023

Conversation

kristinapathak
Copy link
Contributor

@kristinapathak kristinapathak commented Jun 22, 2023

Description: Adds a MeasurementProcessor interface, as a prototype for a potential OTel specification and as a necessary feature for Lightstep's internal use.

@kristinapathak kristinapathak force-pushed the jmacd/context_measurement branch from 6f4779d to 0f2f297 Compare June 22, 2023 00:11
@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2023

Codecov Report

Patch coverage: 85.71% and no project coverage change.

Comparison is base (dc5bdc6) 89.39% compared to head (ee74846) 89.40%.

❗ Current head ee74846 differs from pull request most recent head 76ab7f1. Consider uploading reports for the commit 76ab7f1 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #493   +/-   ##
=======================================
  Coverage   89.39%   89.40%           
=======================================
  Files          62       62           
  Lines        3592     3595    +3     
=======================================
+ Hits         3211     3214    +3     
  Misses        287      287           
  Partials       94       94           
Impacted Files Coverage Δ
lightstep/sdk/metric/sdkinstrument/performance.go 100.00% <ø> (ø)
lightstep/sdk/metric/internal/syncstate/sync.go 96.77% <85.71%> (+0.10%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@jmacd jmacd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kristinapathak kristinapathak marked this pull request as ready for review June 26, 2023 15:51
@kristinapathak kristinapathak requested a review from jmacd June 26, 2023 23:37
@kristinapathak kristinapathak force-pushed the jmacd/context_measurement branch from 43a6c57 to 76ab7f1 Compare June 27, 2023 02:28
@jmacd jmacd changed the title Jmacd/context measurement Add measurement processor support Jun 27, 2023
@jmacd jmacd merged commit c94b43c into main Jun 27, 2023
@kristinapathak kristinapathak deleted the jmacd/context_measurement branch June 27, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants