Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove access token length check #412

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Conversation

PFacheris
Copy link
Contributor

@PFacheris PFacheris commented Mar 17, 2023

Description: A recent attempt to integrate this library with lightstep.com requires use of an access token of varying length (encoded as a JWT). Currently this is disallowed by the library due to the strict length requirements on the access token. This PR removes that check.

Link to tracking Issue: N/A

Testing: Fork tested in an application that makes use of the launcher. It is configured via

launcher.ConfigureOpentelemetry(
    launcher.WithServiceName(config.App.Name),
    launcher.WithServiceVersion(config.App.Version),
    launcher.WithMetricsEnabled(false)
)

and the access token is set via LS_ACCESS_TOKEN env var.

Documentation: N/A

@jmacd jmacd requested review from jmacd and codeboten March 17, 2023 16:30
@jmacd
Copy link
Contributor

jmacd commented Mar 17, 2023

@codeboten and @carlosalberto What do you think? I think customers are interested in using OTel collectors that are capable of adding access tokens on behalf of clients, so we can relax this restriction, yes?

@MadVikingGod
Copy link
Contributor

I think this makes sense. We could also leave it as a warning if the len>0 but not one of the prescribed lengths.

@codeboten codeboten merged commit 1c65a94 into lightstep:main Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants