Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to OTel-Go Metrics API @ v0.35 #381

Merged
merged 10 commits into from
Feb 15, 2023
Merged

Update to OTel-Go Metrics API @ v0.35 #381

merged 10 commits into from
Feb 15, 2023

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented Feb 15, 2023

Description: This is a substantial change in the OTel-Go metrics API, particularly for asynchronous instruments.

Link to tracking Issue:
Fixes #367.

Testing: Some new testing added -- because there are new APIs. The new APIs that are tested: async instrument with single callback in-line, async instrument callback unregister.

@jmacd
Copy link
Contributor Author

jmacd commented Feb 15, 2023

Build failure is difficult to explain -- stems from my use of go.work that had worked around the problem. 😢

@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2023

Codecov Report

Base: 87.66% // Head: 87.84% // Increases project coverage by +0.18% 🎉

Coverage data is based on head (776e840) compared to base (0b5a22b).
Patch coverage: 94.48% of modified lines in pull request are covered.

❗ Current head 776e840 differs from pull request most recent head f46eec6. Consider uploading reports for the commit f46eec6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #381      +/-   ##
==========================================
+ Coverage   87.66%   87.84%   +0.18%     
==========================================
  Files          77       74       -3     
  Lines        4159     4205      +46     
==========================================
+ Hits         3646     3694      +48     
+ Misses        441      438       -3     
- Partials       72       73       +1     
Impacted Files Coverage Δ
lightstep/instrumentation/runtime/builtin.go 72.72% <57.14%> (ø)
lightstep/instrumentation/host/host.go 78.21% <80.76%> (+2.54%) ⬆️
lightstep/sdk/metric/internal/asyncstate/async.go 93.87% <85.00%> (-6.13%) ⬇️
examples/metrics/metrics.go 84.05% <100.00%> (ø)
lightstep/instrumentation/cputime/cputime.go 83.33% <100.00%> (-0.67%) ⬇️
lightstep/sdk/metric/asyncinst.go 100.00% <100.00%> (ø)
...ghtstep/sdk/metric/internal/asyncstate/callback.go 100.00% <100.00%> (ø)
lightstep/sdk/metric/internal/syncstate/sync.go 97.61% <100.00%> (+0.05%) ⬆️
lightstep/sdk/metric/internal/test/test.go 100.00% <100.00%> (ø)
lightstep/sdk/metric/meter.go 100.00% <100.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jmacd jmacd changed the title Update to OTel-Go Metrics API @ v0.36 Update to OTel-Go Metrics API @ v0.35 Feb 15, 2023
@jmacd jmacd merged commit 1fb5140 into main Feb 15, 2023
@jmacd jmacd deleted the jmacd/update_113 branch February 15, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Depending on otel v1.12.0 causes compiler errors
3 participants