Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retract 1.10.0, prepare 1.10.1 #261

Merged
merged 2 commits into from
Aug 29, 2022
Merged

retract 1.10.0, prepare 1.10.1 #261

merged 2 commits into from
Aug 29, 2022

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented Aug 29, 2022

Description: Retract 1.10.0; release 1.10.1 without the change of temporality preference.

Link to tracking Issue:
Fixes #260

Testing: Reverts the change in one test.

Documentation: Updates the temporality preference docs to be more direct.

@jmacd jmacd requested a review from kayousterhout August 29, 2022 20:31
@codecov-commenter
Copy link

Codecov Report

Base: 94.32% // Head: 94.23% // Decreases project coverage by -0.08% ⚠️

Coverage data is based on head (5efd356) compared to base (5e273ff).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #261      +/-   ##
==========================================
- Coverage   94.32%   94.23%   -0.09%     
==========================================
  Files          66       66              
  Lines        3505     3505              
==========================================
- Hits         3306     3303       -3     
- Misses        152      155       +3     
  Partials       47       47              
Impacted Files Coverage Δ
launcher/config.go 88.94% <ø> (ø)
pipelines/metrics.go 65.64% <0.00%> (-2.30%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jmacd jmacd merged commit b116d61 into main Aug 29, 2022
@jmacd jmacd deleted the jmacd/retract branch August 29, 2022 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid breaking temporality preference default
4 participants