-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an example, link it in the README #219
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but there is another reference to test.NewServer
in examples/tracing/trace_test.go
that is passing in an argument. See: https://github.com/lightstep/otel-launcher-go/pull/219/files#file-examples-tracing-trace_test-go-L27.
Codecov Report
@@ Coverage Diff @@
## main #219 +/- ##
=======================================
Coverage 94.26% 94.26%
=======================================
Files 62 62
Lines 3312 3312
=======================================
Hits 3122 3122
Misses 145 145
Partials 45 45
Continue to review full report at Codecov.
|
Fixed, PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left one non-blocking comment, otherwise this looks great. Thanks for putting this together!
Description: Add an example to test the smallest configuration of the Lightstep metrics SDK for stand-alone use.
Testing: This is a test.
Documentation: Linked from README.md