Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an example, link it in the README #219

Merged
merged 4 commits into from
Jul 18, 2022
Merged

Add an example, link it in the README #219

merged 4 commits into from
Jul 18, 2022

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented Jul 14, 2022

Description: Add an example to test the smallest configuration of the Lightstep metrics SDK for stand-alone use.

Testing: This is a test.

Documentation: Linked from README.md

@jmacd jmacd requested a review from mwear July 14, 2022 20:24
Copy link

@mwear mwear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but there is another reference to test.NewServer in examples/tracing/trace_test.go that is passing in an argument. See: https://github.com/lightstep/otel-launcher-go/pull/219/files#file-examples-tracing-trace_test-go-L27.

Joshua MacDonald added 2 commits July 14, 2022 23:26
@codecov-commenter
Copy link

Codecov Report

Merging #219 (8955aae) into main (b60529d) will not change coverage.
The diff coverage is 33.33%.

@@           Coverage Diff           @@
##             main     #219   +/-   ##
=======================================
  Coverage   94.26%   94.26%           
=======================================
  Files          62       62           
  Lines        3312     3312           
=======================================
  Hits         3122     3122           
  Misses        145      145           
  Partials       45       45           
Impacted Files Coverage Δ
pipelines/test/test.go 93.93% <33.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b60529d...8955aae. Read the comment docs.

@jmacd
Copy link
Contributor Author

jmacd commented Jul 15, 2022

Fixed, PTAL.

Copy link
Contributor

@jaronoff97 jaronoff97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left one non-blocking comment, otherwise this looks great. Thanks for putting this together!

@jmacd jmacd merged commit f3397c8 into main Jul 18, 2022
@jmacd jmacd deleted the jmacd/example branch July 18, 2022 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants