Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightstep metrics SDK: Fix race condition in sync-delta code path #205

Merged
merged 1 commit into from
Jul 8, 2022

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented Jul 8, 2022

Description:
There was a race in the delta-temporality collection path for synchronous instruments when multiple readers were present. This fixes that race (and a test that was validating the bad behavior).

Link to tracking Issue: Fixes #204

Testing: Lots of -count=1000 testing to reproduce locally what seems easy in the CI pipeline

@jmacd jmacd requested a review from jaronoff97 July 8, 2022 19:29
@codecov-commenter
Copy link

Codecov Report

Merging #205 (4b4d1bc) into main (38d5716) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 4b4d1bc differs from pull request most recent head ce2f719. Consider uploading reports for the commit ce2f719 to get more accurate results

@@           Coverage Diff           @@
##             main     #205   +/-   ##
=======================================
  Coverage   94.29%   94.29%           
=======================================
  Files          62       62           
  Lines        3260     3263    +3     
=======================================
+ Hits         3074     3077    +3     
  Misses        142      142           
  Partials       44       44           
Impacted Files Coverage Δ
lightstep/sdk/metric/internal/syncstate/sync.go 100.00% <100.00%> (ø)
...htstep/sdk/metric/internal/viewstate/collectors.go 95.45% <100.00%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb8cfe2...ce2f719. Read the comment docs.

@jmacd jmacd merged commit e1ddd9c into main Jul 8, 2022
@jmacd jmacd deleted the jmacd/bugfix branch July 8, 2022 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test flake: lightstep/sdk/metric/internal/syncstate
3 participants