Give distinct names to the trace/metrics batch processors in the otel…

…col-based exporters (#587) **Description:** The trace and metric SDKs both use the same processor with the same name, which makes a single-writer rule violation. Insert "trace" and "metric" accordingly, following the pattern used for the exporters (which _did_ distinguish the two already).
lightstep · Dec 13, 2023 · 55a06b4 · 55a06b4
1 parent ffdd1b8
commit 55a06b4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lightstep/sdk/metric/exporters/otlp/otelcol/client.go b/lightstep/sdk/metric/exporters/otlp/otelcol/client.go
@@ -169,7 +169,7 @@ func NewExporter(ctx context.Context, cfg Config) (metric.PushExporter, error) {
 	}
 
 	bset := processor.CreateSettings{
-		ID:                component.NewID("otel/sdk/batch"),
+		ID:                component.NewID("otel/sdk/metric/batch"),
 		TelemetrySettings: c.settings.TelemetrySettings,
 		BuildInfo:         c.settings.BuildInfo,
 	}

diff --git a/lightstep/sdk/trace/exporters/otlp/otelcol/client.go b/lightstep/sdk/trace/exporters/otlp/otelcol/client.go
@@ -182,7 +182,7 @@ func NewExporter(ctx context.Context, cfg Config) (trace.SpanExporter, error) {
 	}
 
 	bset := processor.CreateSettings{
-		ID:                component.NewID("otel/sdk/batch"),
+		ID:                component.NewID("otel/sdk/trace/batch"),
 		TelemetrySettings: c.settings.TelemetrySettings,
 		BuildInfo:         c.settings.BuildInfo,
 	}