Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix REST parameter issue in GET call #445

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Fix REST parameter issue in GET call #445

merged 2 commits into from
Aug 9, 2023

Conversation

guggero
Copy link
Member

@guggero guggero commented Aug 9, 2023

Fixes #428.

@guggero guggero requested review from positiveblue and ffranr August 9, 2023 11:35
@jharveyb jharveyb self-requested a review August 9, 2023 18:34
jharveyb
jharveyb approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@jharveyb jharveyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I imagine we may have some other fields that need this treatment, could make this more generic later on.

Roasbeef
Roasbeef approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐊

@Roasbeef Roasbeef added this pull request to the merge queue Aug 9, 2023
Merged via the queue into main with commit 7077464 Aug 9, 2023
@guggero guggero deleted the bug-fixes branch August 10, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Roasbeef Roasbeef Roasbeef approved these changes

@jharveyb jharveyb jharveyb approved these changes

@positiveblue positiveblue Awaiting requested review from positiveblue

@ffranr ffranr Awaiting requested review from ffranr

Assignees
No one assigned
Labels
None yet
Projects
Taproot-Assets Project Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug]: oneof in REST query parameters doesn't work
3 participants
@guggero @Roasbeef @jharveyb