commitment: splits shouldn't inherit locktime from inputs #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10533902922Details
💛 - Coveralls |
In this commit, we fix an existing bug related to lock times and split commitments. Before this commit, if an input had a relative lock time, then when we went to make the new split assets, we would _copy_ that value into the split. This isn't correct as the input is valid/confirmed, so we don't need to copy over the lock time information. The prior behavior would cause certain classes of spends to fail, as we would be validating a new root asset that has no lock time, but the root asset split inserted into the split commitment would be carrying the old lock time. When verifying the split, we would set the lock times of the split to that of the new asset: https://github.com/lightninglabs/taproot-assets/blob/e893dee87e9d8f0de53b8ee9e2527add80df6491/vm/vm.go#L305-L307. As we copied over the lock time from the input, we would now effectively invalid the split commitment. Fixes #1099
guggero
force-pushed
the
fix-split-locktime
branch
from
523d723 to
317559c
Compare
guggero
approved these changes
Aug 23, 2024
|
Updated lightninglabs/lightning-terminal#825 to confirm this fully fixes the issue. |
jharveyb
approved these changes
Aug 23, 2024
SGTM, was thinking that too, can tack it on. |
It appears that the underlying library may `nil` out the `rawConn` after the transfer is finished. We can avoid a panic here by only closing if the `rawConn` is non-nil.
`CopySpendTemplate` is similar to `Copy` but sheds some fields that don't need to be carried along when making a copy of an input to spend. This includes the split commitment root, and time lock information.
|
Implemented here: 881ecaf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, we fix an existing bug related to lock times and split commitments. Before this commit, if an input had a relative lock time, then when we went to make the new split assets, we would copy that value into the split. This isn't correct as the input is valid/confirmed, so we don't need to copy over the lock time information.
The prior behavior would cause certain classes of spends to fail, as we would be validating a new root asset that has no lock time, but the root asset split inserted into the split commitment would be carrying the old lock time. When verifying the split, we would set the lock times of the split to that of the new asset:
taproot-assets/vm/vm.go
Lines 305 to 307 in e893dee
As we copied over the lock time from the input, we would now effectively invalid the split commitment.
Fixes #1099