Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpcserver: populate auction_type in the ListOrders endpoint #412

Merged
merged 1 commit into from
Nov 6, 2022
Merged

rpcserver: populate auction_type in the ListOrders endpoint #412

merged 1 commit into from
Nov 6, 2022

Conversation

positiveblue
Copy link
Contributor

Fix #411

guggero
guggero approved these changes Nov 4, 2022
View reviewed changes
Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

dstadulis
dstadulis approved these changes Nov 5, 2022
View reviewed changes
Copy link
Contributor

@dstadulis dstadulis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@positiveblue positiveblue merged commit f6f2182 into lightninglabs:master Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstadulis dstadulis dstadulis approved these changes

@guggero guggero guggero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug]: pool order list return orders with the incorrect auction_type
3 participants
@positiveblue @guggero @dstadulis