Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passes references to the public and secret keys to sign/verify #974

Merged
merged 1 commit into from
Jun 29, 2021

Conversation

sr-gi
Copy link
Contributor

@sr-gi sr-gi commented Jun 29, 2021

sign/verify should not take ownership of the keys. Didn't pay enough attention when originally implementing this.

sign/verify should not take ownership of the keys.
@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #974 (c1d2d15) into main (ecddfe1) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #974      +/-   ##
==========================================
- Coverage   90.65%   90.64%   -0.01%     
==========================================
  Files          60       60              
  Lines       30398    30398              
==========================================
- Hits        27558    27555       -3     
- Misses       2840     2843       +3     
Impacted Files Coverage Δ
lightning/src/util/message_signing.rs 93.10% <100.00%> (ø)
lightning/src/ln/channelmanager.rs 83.85% <0.00%> (-0.05%) ⬇️
lightning/src/ln/functional_tests.rs 97.12% <0.00%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecddfe1...c1d2d15. Read the comment docs.

@TheBlueMatt TheBlueMatt merged commit 3791a7b into lightningdevkit:main Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants