Increase poll::Validate visibility to pub #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #956 +/- ##
==========================================
- Coverage 90.59% 90.57% -0.02%
==========================================
Files 60 60
Lines 30423 30423
==========================================
- Hits 27561 27555 -6
- Misses 2862 2868 +6
Continue to review full report at Codecov.
|
|
Hmm, do we actually need to expose |
Yeah, just needed for callers. |
jkczyz
force-pushed
the
2021-06-validate-pub
branch
from
2f7065e to
14b79bc
Compare
TheBlueMatt
reviewed
Jun 17, 2021
Previously, poll::Validate was pub(crate) to force external implementors of Poll to define their implementation in terms of ChainPoller. This was because ChainPoller::look_up_previous_header checks for consistency between headers and any errors would be checked at that level rather than by the caller. Otherwise, if performed by the caller, a Poll implementation would not be aware if the underlying BlockSource was providing bad data and therefore couldn't react accordingly. Widening the visibility to pub relaxes this requirement, although it's still encourage to use ChainPoller to implement Poll. This permits either copying or moving lightning-block-sync's test utilities to a separate crate since they use poll::Validate.
jkczyz
force-pushed
the
2021-06-validate-pub
branch
from
14b79bc to
7302c8c
Compare
TheBlueMatt
approved these changes
Jun 18, 2021
valentinewallace
approved these changes
Jun 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Widening the visibility to pub relaxes this requirement permits either copying or moving
lightning-block-sync's test utilities to a separate crate since they usepoll::Validate.