Add the ability to fetch a probability from live liquidity bounds #3420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkczyz
reviewed
Nov 22, 2024
|
Also pushed a new method which I actually need for the simulator. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3420 +/- ##
==========================================
+ Coverage 89.61% 90.41% +0.80%
==========================================
Files 129 130 +1
Lines 105506 113457 +7951
Branches 105506 113457 +7951
==========================================
+ Hits 94544 102585 +8041
+ Misses 8208 8150 -58
+ Partials 2754 2722 -32 ☔ View full report in Codecov by Sentry. |
jkczyz
reviewed
Nov 25, 2024
|
Tagging 0.1 just because I want this for the sim replay and don't want to rely on a branch there. |
We already expose the estimated success probability from the historical liquidity bounds from `historical_estimated_payment_success_probability`, but we don't do that for the live liquidity bounds. Here we add a `live_estimated_payment_success_probability` which exposes the probability result from the live liquidity bounds as well.
`historical_estimated_payment_success_probability` exposes the historical success probability estimator publicly, but only allows fetching data from channels where we have sufficient information. In the previous commit, `live_estimated_payment_success_probability` was added to enable querying the live bounds success probability estimator. Sadly, while the historical success probability estimator falls back to the live probability estimator, it does so with a different final parameter to `success_probability`, making `live_estimated_payment_success_probability` not useful for calculating the actual historical model output when we have insufficient data. Instead, here, we add a new parameter to `historical_estimated_payment_success_probability` which determines whether it will return fallback data from the live model instead.
TheBlueMatt
force-pushed
the
2024-11-live-success-prob
branch
from
0b39756 to
d3efe5c
Compare
|
Squashed without further changes. |
jkczyz
approved these changes
Dec 2, 2024
|
Just landing this. Its a new public method that, if its wrong, just means peoples' stats will be wrong. Its not actually used when sending payments. Its also trivial. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already expose the estimated success probability from the historical liquidity bounds from
historical_estimated_payment_success_probability, but we don't do that for the live liquidity bounds.Here we add a
live_estimated_payment_success_probabilitywhich exposes the probability result from the live liquidity bounds as well.