Make monitor update name public #3376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yellowred
force-pushed
the
yellowred/monitor_update_name_pub
branch
from
6866d3a to
ca0295b
Compare
|
Making these public seems reasonable, but to do so we should substantially improve the documentation on them - what are they used for, how is the conversion done, why is it done, why would a user want to use these structs directly, etc |
yellowred
force-pushed
the
yellowred/monitor_update_name_pub
branch
2 times, most recently
from
cd4714f to
25e4107
Compare
|
@TheBlueMatt Added docs for all the structs and methods with examples. I did not mention specific details of custom persistence implementation, for example that it should impl Persist and use KVStore, leaving it to a user to figure out if they need it or not. |
yellowred
force-pushed
the
yellowred/monitor_update_name_pub
branch
from
25e4107 to
b42a77e
Compare
|
Fixed formatting. |
These structs are meant for MonitoringUpdatingPersister implementation, but some external implementations may still reuse them, so going to make them public.
yellowred
force-pushed
the
yellowred/monitor_update_name_pub
branch
from
b42a77e to
01529dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These structs are meant for MonitoringUpdatingPersister implementation, but some external implementations may still reuse them, so going to make them public.