Quick #3010 followups #3311
Merged
Quick #3010 followups #3311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arik-so
reviewed
Sep 19, 2024
|
LGTM less the typo, though |
`creates_and_pays_for_offer_with_retry` intends to check that we re-send a BOLT 12 `invoice_request` in response to a `message_received` call, but doesn't actually test that there were no messages in the outbound buffer after the initial send, which we do here.
While `message_received` purports to be called on every message, prior to the message, doing so on `Init` messages means we have to call `message_received` while holding the per-peer mutex, which can cause some lock contention. Instead, here, we call `message_received` after processing `Init` messages (which is probably more useful anyway - the peer isn't really "connected" until we've processed the `Init` messages), allowing us to call it unlocked.
TheBlueMatt
force-pushed
the
2024-09-3010-followups
branch
from
dd9407b to
d156b2e
Compare
|
Fixed, sorry. |
arik-so
approved these changes
Sep 30, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3311 +/- ##
==========================================
+ Coverage 89.63% 91.17% +1.53%
==========================================
Files 126 126
Lines 102383 114710 +12327
Branches 102383 114710 +12327
==========================================
+ Hits 91776 104588 +12812
+ Misses 7877 7560 -317
+ Partials 2730 2562 -168
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Pretty simple and three people have looked at it so just landing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few minor things I noticed in the second-pass review.