Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-export lightning_types in top-level lightning modules #3253

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

TheBlueMatt
Copy link
Collaborator

Since we now have many types in one place, it makes sense to export them in that place. Further, doing so finally somewhat starts to reduce our lightning::ln module size, which historically is the dumping ground for everything when most things really should be top-level modules in lightning.

Here we take a step in the right direction by exporting lightning_types as lightning::types and encouraging users to use those paths directly rather than the ones in lightning::ln.

Since we now have many types in one place, it makes sense to export
them in that place. Further, doing so finally somewhat starts to
reduce our `lightning::ln` module size, which historically is the
dumping ground for everything when most things really should be
top-level modules in `lightning`.

Here we take a step in the right direction by exporting
`lightning_types` as `lightning::types` and encouraging users to
use those paths directly rather than the ones in `lightning::ln`.
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.70%. Comparing base (ccce9d9) to head (1e1b8ec).
Report is 34 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3253      +/-   ##
==========================================
+ Coverage   89.68%   89.70%   +0.01%     
==========================================
  Files         124      124              
  Lines      102386   102386              
  Branches   102386   102386              
==========================================
+ Hits        91827    91844      +17     
+ Misses       7857     7839      -18     
- Partials     2702     2703       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tnull tnull merged commit 680d399 into lightningdevkit:main Aug 20, 2024
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants