Re-export lightning_types
in top-level lightning
modules
#3253
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we now have many types in one place, it makes sense to export them in that place. Further, doing so finally somewhat starts to reduce our
lightning::ln
module size, which historically is the dumping ground for everything when most things really should be top-level modules inlightning
.Here we take a step in the right direction by exporting
lightning_types
aslightning::types
and encouraging users to use those paths directly rather than the ones inlightning::ln
.