-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Readable
for Offer
and Refund
#2965
Implement Readable
for Offer
and Refund
#2965
Conversation
I believe the intended serialization for all of this is |
Hmmm, but for example in LDK Node's upcoming |
Yea, I mean I'm okay with supporting more here, just noting that we've historically just suggested string'ifying the BOLT11 things. |
Is it desirable to parse the offer into all of its in-memory parts? Like, if you were listing most recent payments, showing the bech32 string might be more desirable, only parsing it when examining a specific payment. I guess I don't have a strong feeling about whether we should add |
Hmm, so far the payment store holds and returns the full Rust objects, which would allow users to take advantage of the full API. While I agree that for display purposes showing the bech32 could make more sense, it would still be good to maintain easy access to any of the provided |
Yeah, I'm not opposed. Seems we need to do this for other types as well when including in an event. |
When storing `Offer`s, it's useful for them to implement LDK's deserialization trait.
When storing `Refund`s, it's useful for them to implement LDK's deserialization trait.
454477d
to
fc14495
Compare
Rebased to resolve minor conflict. |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2965 +/- ##
==========================================
+ Coverage 89.91% 90.52% +0.60%
==========================================
Files 117 117
Lines 97383 102482 +5099
Branches 97383 102482 +5099
==========================================
+ Hits 87566 92774 +5208
- Misses 7254 7257 +3
+ Partials 2563 2451 -112 ☔ View full report in Codecov by Sentry. |
In order to make storing
Offer
andRefund
objects easier, we here implementReadable
for them (both already implementWriteable
).As I'm not sure if this was omitted on purpose so far, waiting on a concept ACK from @jkczyz.
If we agree we want this, we should probably also implement
Writeable
/Readable
forBolt11Invoice
, and add serde de/serialization forOffer
/Refund
as requested here.