Expose onion_message items directly rather than via re-exports
#2821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBlueMatt
force-pushed
the
2024-01-om-direct-export
branch
2 times, most recently
from
81b4fe3 to
eec1923
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2821 +/- ##
==========================================
+ Coverage 88.43% 89.27% +0.84%
==========================================
Files 114 114
Lines 91957 96071 +4114
Branches 91957 96071 +4114
==========================================
+ Hits 81326 85772 +4446
+ Misses 8115 7870 -245
+ Partials 2516 2429 -87 ☔ View full report in Codecov by Sentry. |
TheBlueMatt
force-pushed
the
2024-01-om-direct-export
branch
from
eec1923 to
7cc2413
Compare
jkczyz
reviewed
Jan 10, 2024
When we originally added the `onion_message` module, there weren't a lot of public items in it, and it didn't make a lot of sense to export the whole sub-module structure publicly. So, instead, we exported the public items via re-exports directly in the `onion_message` top-level module. However, as time went on, more and more things entered the module, which left the top-level module rather cluttered. Worse, in 0.0.119, we exposed `onion_message::messenger::SendSuccess` via the return type of `send_message`, but forgot to re-export the enum itself, making it impossible to actually use from external code. Here we address both issues and simply replace the re-export with the underlying sub-module structure.
TheBlueMatt
force-pushed
the
2024-01-om-direct-export
branch
from
91dae2e to
ab66143
Compare
|
Squashed without changes. |
jkczyz
approved these changes
Jan 11, 2024
valentinewallace
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we originally added the
onion_messagemodule, there weren't a lot of public items in it, and it didn't make a lot of sense to export the whole sub-module structure publicly. So, instead, we exported the public items via re-exports directly in theonion_messagetop-level module. However, as time went on, more and more things entered the module, which left the top-level module rather cluttered.Worse, in 0.0.119, we exposed
onion_message::messenger::SendSuccessvia the return type ofsend_message, but forgot to re-export the enum itself, making it impossible to actually use from external code.Here we address both issues and simply replace the re-export with the underlying sub-module structure.