Add some public utilities to lightning_invoice
#2730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benthecarman
force-pushed
the
invoice-utils
branch
from
05d3689 to
8f2165d
Compare
benthecarman
force-pushed
the
invoice-utils
branch
from
8f2165d to
1959422
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2730 +/- ##
==========================================
- Coverage 88.80% 88.70% -0.10%
==========================================
Files 113 113
Lines 89170 89355 +185
Branches 89170 89355 +185
==========================================
+ Hits 79188 79263 +75
- Misses 7729 7839 +110
Partials 2253 2253 ☔ View full report in Codecov by Sentry. |
TheBlueMatt
reviewed
Nov 13, 2023
TheBlueMatt
reviewed
Nov 14, 2023
benthecarman
force-pushed
the
invoice-utils
branch
from
acb1ebb to
7a3b46e
Compare
TheBlueMatt
reviewed
Nov 14, 2023
benthecarman
force-pushed
the
invoice-utils
branch
from
7a3b46e to
c2c6c4d
Compare
shaavan
reviewed
Nov 15, 2023
shaavan
reviewed
Nov 15, 2023
There was a problem hiding this comment.
Concept ACK
Nice work on the new public utilities! They look solid, and I couldn't spot any potential bugs or vulnerabilities. The switch from String to UntrustedString for 'Description' is a smart move too.
Aside from the comment here, I give this pull request a big thumbs up! 👍 Great job!
benthecarman
force-pushed
the
invoice-utils
branch
from
c2c6c4d to
e80e8c8
Compare
valentinewallace
approved these changes
Nov 15, 2023
TheBlueMatt
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on adding more testing infra to mutiny. These are some things that would make our life easier, so we can compare/construct things properly.