Complete underpaying HTLCs support #2715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnull
approved these changes
Nov 7, 2023
shaavan
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
ACK
- Correctly includes the counterparty_skimmed_fee_msat as an optional tlv-based message.
- Since LSPs running older versions of LDK won't be able to set skimmed_fees for opening JIT channels, it makes sense the value will be 0 for older LSP providers.
- The link added to the LSP specs document, directing to the JIT channels explanation is correct.
TheBlueMatt
approved these changes
Nov 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1999.