Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes Features::from_be_bytes public #2640

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lightning/src/ln/features.rs
Original file line number Diff line number Diff line change
Expand Up @@ -718,7 +718,11 @@ impl<T: sealed::Context> Features<T> {
Ok(())
}

fn from_be_bytes(mut flags: Vec<u8>) -> Features<T> {
/// Create a [`Features`] given a set of flags, in big-endian. This is in byte order from
/// most on-the-wire encodings.
///
/// This is not exported to bindings users as we don't support export across multiple T
pub fn from_be_bytes(mut flags: Vec<u8>) -> Features<T> {
flags.reverse(); // Swap to little-endian
Self {
flags,
Expand Down