-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve block connection logging #2559
Closed
Closed
Changes from 4 commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
1cece1b
logging channel_id of connected txids
Sharmalm b3c824f
Merge branch 'lightningdevkit:main' into main
Sharmalm b2236a6
logging confirmed txid
Sharmalm 7272dc5
Merge remote-tracking branch 'refs/remotes/origin/main'
Sharmalm 743f548
logging in channel monitor
Sharmalm 10ea10e
logging all filtered txids
Sharmalm 3477eea
adding txid to filter and logging best_block_update
Sharmalm 8f1e8b6
Handle if funding output is in a coinbase transaction
benthecarman 3b30a80
Support creating coinbase funding transactions in tests
benthecarman 87ac1bf
Add test for coinbase funding transactions
dunxen fe0a7fc
Add constructor to `RouteParameters`
tnull 203a847
Have `get_route` take `RouteParameters`
tnull 976d077
Have `Route` hold `RouteParameters`
tnull 539d60d
Include overpaid value in `Route::get_total_fees`
tnull 9963e16
Improve `Route::get_total_amount` docs
tnull 40d901f
Log each condition that was violated for a stale monitor
waterson b874ccf
Fix misspelling, s/and/but/.
waterson eb593db
logging channel_id of connected txids
Sharmalm 62afba6
logging confirmed txid
Sharmalm e052324
Add RFC4648 base32 `encode` and `decode` functions
jbesraa 84e3ba6
Move `zbase32` implementation to `base32` file
jbesraa b401464
Fix indent in `message_signing.rs`
jbesraa 4d31af3
Implement `from_str` trait for `NetAddress`
jbesraa ef14292
Add `KVStore` interface trait
tnull e82f427
Update `lightning-persister` crate
tnull 5591d34
Add `test_utils`
tnull e9321a5
Add `FilesystemStore`
tnull 485cc59
Add `read_channel_monitors` utility
tnull a7ce0e3
Migrate to `KVStore`/`FilesystemStore`
tnull 20433de
Migrate `FilesystemPersister` tests to `FilesystemStore`
tnull bc27771
Add benchmarking for `FilesystemStore`
tnull d731a35
Add `TestStore` implementation of `KVStore`
tnull 446e078
Add an InvoiceRequestFailed event
jkczyz 5c4b7ad
Add PendingOutboundPayment::AwaitingInvoice
jkczyz 1f2d0e7
Move IDEMPOTENCY_TIMEOUT_TICKS to where it is used
jkczyz 9c4739a
Test for removing stale AwaitingInvoice payments
jkczyz 1ce341b
Test removing abandoned AwaitingInvoice payments
jkczyz 2e6a640
Add PendingOutboundPayment::InvoiceReceived
jkczyz 1cfd3c5
Refactor OutboundPayments::retry_payment_internal
jkczyz eb8b14b
Rename OutboundPayments::retry_payment_internal
jkczyz c8f1fe6
Merge branch 'main' of https://github.com/Sharmalm/rust-lightning
Sharmalm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think we should log every transaction, as many users actually connect all transactions in a block. Instead, we should look for transactions we care about, and maybe only actually add logging in ChannelMonitor where we can do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok