Force enqueue second forward event for phantom receives #2395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #2395 +/- ##
==========================================
- Coverage 90.32% 90.32% -0.01%
==========================================
Files 106 106
Lines 54968 54979 +11
Branches 54968 54979 +11
==========================================
+ Hits 49651 49659 +8
- Misses 5317 5320 +3
☔ View full report in Codecov by Sentry. |
wpaulino
force-pushed
the
phantom-deduped-forward-event
branch
from
4cb4918 to
313af81
Compare
TheBlueMatt
reviewed
Jul 8, 2023
alecchendev
reviewed
Jul 9, 2023
wpaulino
force-pushed
the
phantom-deduped-forward-event
branch
from
313af81 to
89cf906
Compare
This was a regression resulting from f2453b7 since we now process events in a loop until there aren't any left. Processing events is done in batches and they are not removed until we're done processing each batch. Since handling a `PendingHTLCsForwardable` event will call back into the `ChannelManager`, we'll still see the original forwarding event not removed. Phantom payments will need an additional forwarding event before being claimed to make them look real by taking more time.
wpaulino
force-pushed
the
phantom-deduped-forward-event
branch
from
89cf906 to
81722ca
Compare
TheBlueMatt
approved these changes
Jul 10, 2023
tnull
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a regression resulting from f2453b7 since we now process events in a loop until there aren't any left. Phantom receives rely on two calls to
ChannelManager::process_pending_htlc_forwardsbefore emiting thePaymentClaimableevent, providing better privacy to make them look "real" by taking more time.Fixes #2378.