Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define a default MessageRouter implementation #2384

Merged
merged 1 commit into from
Jul 2, 2023

Conversation

jkczyz
Copy link
Contributor

@jkczyz jkczyz commented Jun 29, 2023

Otherwise, users need to define one when using "Simple" type aliases.

@TheBlueMatt TheBlueMatt added this to the 0.0.116 milestone Jun 30, 2023
@TheBlueMatt
Copy link
Collaborator

Basically LGTM once CI passes.

Otherwise, users need to define one when using "Simple" type aliases.
@jkczyz jkczyz force-pushed the 2023-06-message-router branch from c9be056 to 129dd30 Compare June 30, 2023 14:29
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (bd12067) 90.32% compared to head (129dd30) 90.32%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2384   +/-   ##
=======================================
  Coverage   90.32%   90.32%           
=======================================
  Files         106      106           
  Lines       54951    54996   +45     
  Branches    54951    54996   +45     
=======================================
+ Hits        49633    49674   +41     
- Misses       5318     5322    +4     
Impacted Files Coverage Δ
lightning-background-processor/src/lib.rs 82.58% <ø> (ø)
lightning/src/ln/peer_handler.rs 61.77% <ø> (ø)
lightning/src/onion_message/messenger.rs 86.19% <0.00%> (-1.25%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TheBlueMatt TheBlueMatt merged commit 86fd9e7 into lightningdevkit:main Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants