Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail RGS data processing early if there is a chain hash mismatch #2324

Merged

Conversation

dunxen
Copy link
Contributor

@dunxen dunxen commented May 29, 2023

No point in doing any extra processing if we don't even have a match for the chain hash.

Resolves #2242.

No point in doing any extra processing if we don't even have a match
for the chain hash.
@dunxen dunxen force-pushed the 2023-05-rgscheckgenesishash branch from 7109301 to 142fdca Compare May 29, 2023 14:16
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 95.00% and project coverage change: -0.02 ⚠️

Comparison is base (4dce209) 90.79% compared to head (142fdca) 90.78%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2324      +/-   ##
==========================================
- Coverage   90.79%   90.78%   -0.02%     
==========================================
  Files         104      104              
  Lines       53033    53052      +19     
  Branches    53033    53052      +19     
==========================================
+ Hits        48153    48163      +10     
- Misses       4880     4889       +9     
Impacted Files Coverage Δ
lightning-rapid-gossip-sync/src/processing.rs 92.72% <93.75%> (-1.10%) ⬇️
lightning-background-processor/src/lib.rs 82.63% <100.00%> (ø)
lightning/src/routing/gossip.rs 89.81% <100.00%> (+0.02%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TheBlueMatt TheBlueMatt merged commit 91536ed into lightningdevkit:main May 31, 2023
@dunxen dunxen deleted the 2023-05-rgscheckgenesishash branch May 31, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check genesis block hash before doing anything else in RGS data processing
4 participants