Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function for updating network graph with announcement with no UTXO resolver #2222

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

benthecarman
Copy link
Contributor

This trivial implementation would be nice to have for implementations that are passing in None when calling network_graph.update_channel_from_announcement as the compiler needs a type to infer. Today the user needs to create their own dummy impl of UtxoLookup when they could just use this one.

@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03 ⚠️

Comparison is base (bc54441) 91.57% compared to head (09e29c8) 91.55%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2222      +/-   ##
==========================================
- Coverage   91.57%   91.55%   -0.03%     
==========================================
  Files         104      104              
  Lines       51553    51745     +192     
  Branches    51553    51745     +192     
==========================================
+ Hits        47212    47377     +165     
- Misses       4341     4368      +27     
Impacted Files Coverage Δ
lightning/src/routing/gossip.rs 89.90% <ø> (ø)
lightning/src/routing/utxo.rs 91.90% <ø> (ø)

... and 20 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TheBlueMatt
Copy link
Collaborator

Can we just expose a wrapper around update_channel_from_announcement instead?

@benthecarman
Copy link
Contributor Author

Can we just expose a wrapper around update_channel_from_announcement instead?

That's a much better idea

@benthecarman benthecarman changed the title Make trivial impl of UtxoLookup public @benthecarman Add function for updating network graph with announcement with no UTXO resolver Apr 24, 2023
@benthecarman benthecarman changed the title @benthecarman Add function for updating network graph with announcement with no UTXO resolver Add function for updating network graph with announcement with no UTXO resolver Apr 24, 2023
Copy link
Collaborator

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops I guess we should have landed this for 115. Oh well.

@TheBlueMatt TheBlueMatt merged commit c182567 into lightningdevkit:main Apr 25, 2023
@benthecarman benthecarman deleted the pub-utxo-resolver branch April 25, 2023 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants