-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add function for updating network graph with announcement with no UTXO resolver #2222
Add function for updating network graph with announcement with no UTXO resolver #2222
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #2222 +/- ##
==========================================
- Coverage 91.57% 91.55% -0.03%
==========================================
Files 104 104
Lines 51553 51745 +192
Branches 51553 51745 +192
==========================================
+ Hits 47212 47377 +165
- Misses 4341 4368 +27
... and 20 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Can we just expose a wrapper around update_channel_from_announcement instead? |
d99f537
to
04f849c
Compare
That's a much better idea |
04f849c
to
09e29c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops I guess we should have landed this for 115. Oh well.
This trivial implementation would be nice to have for implementations that are passing in
None
when callingnetwork_graph.update_channel_from_announcement
as the compiler needs a type to infer. Today the user needs to create their own dummy impl ofUtxoLookup
when they could just use this one.