Move checking of specific require peer feature bits to handlers #1717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Codecov ReportBase: 90.84% // Head: 90.83% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1717 +/- ##
==========================================
- Coverage 90.84% 90.83% -0.02%
==========================================
Files 86 86
Lines 46448 47509 +1061
Branches 46448 47509 +1061
==========================================
+ Hits 42198 43153 +955
- Misses 4250 4356 +106
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
wpaulino
reviewed
Sep 12, 2022
| @@ -6034,7 +6034,12 @@ impl<Signer: Sign, M: Deref , T: Deref , K: Deref , F: Deref , L: Deref > | |||
| } | |||
| } | |||
|
|
|||
| fn peer_connected(&self, counterparty_node_id: &PublicKey, init_msg: &msgs::Init) { | |||
| fn peer_connected(&self, counterparty_node_id: &PublicKey, init_msg: &msgs::Init) -> Result<(), ()> { | |||
| if !init_msg.features.supports_static_remote_key() { | |||
There was a problem hiding this comment.
It's not obvious to me why we wouldn't also disallow peers that don't support payment_secret, since it looks like we'll fail payments that don't have one.
There was a problem hiding this comment.
Payment_secret is really between us and the sender - we can have a channel with someone who doesn't speak payment_secret, and our counterparty can't pay us directly, but we can still receive funds via them.
TheBlueMatt
force-pushed
the
2022-09-req-features-in-handlers
branch
from
dc3e512 to
7e0c8fe
Compare
It appears our code is already correct here, but its also nice to add a quick safety check in `channel.rs` which ensures we will remain idempotent.
In the next commit we'll enforce counterparty `InitFeatures` matching our required set in `ChannelManager`, implying they must be set for many tests where they previously did not need to be (as they were enforced in `PeerManager`, which is not used in functional tests).
As we remove the concept of a global "known/supported" feature set in LDK, we should also remove the concept of a global "required" feature set. This does so by moving the checks for specific required features into handlers. Specifically, it allows the handler `peer_connected` method to return an `Err` if the peer should be disconnected. Only one such required feature bit is currently set - `static_remote_key`, which is required in `ChannelManager`.
TheBlueMatt
force-pushed
the
2022-09-req-features-in-handlers
branch
from
7e0c8fe to
f725c5a
Compare
|
Squashed without change. |
wpaulino
approved these changes
Sep 13, 2022
valentinewallace
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we remove the concept of a global "known/supported" feature set
in LDK, we should also remove the concept of a global "required"
feature set. This does so by moving the checks for specific
required features into handlers.
Specifically, it allows the handler
peer_connectedmethod toreturn an
Errif the peer should be disconnected. Only one suchrequired feature bit is currently set -
static_remote_key, whichis required in
ChannelManager.