Small Cleanups Discovered during Bindings for 0.0.111 #1714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Codecov Report
@@ Coverage Diff @@
## main #1714 +/- ##
==========================================
- Coverage 90.84% 90.80% -0.05%
==========================================
Files 86 86
Lines 46448 46451 +3
Branches 46448 46451 +3
==========================================
- Hits 42198 42180 -18
- Misses 4250 4271 +21
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
TheBlueMatt
force-pushed
the
2022-09-111-bindings-discovered-cleanups
branch
from
89275cd to
7f9df8d
Compare
tnull
reviewed
Sep 12, 2022
TheBlueMatt
force-pushed
the
2022-09-111-bindings-discovered-cleanups
branch
from
7f9df8d to
53aeeeb
Compare
|
ACK 53aeeeb |
tnull
reviewed
Sep 12, 2022
Now that `{Signed,}RawInvoice` implement the std `Hash` trait,
having a method called `hash` is ambiguous.
Instead, we rename the `hash` methods `signed_hash` to make it
clear that the hash is the one used for the purpose of signing the
invoice.
The C bindings generator isn't capable of figuring out if a blanket impl applies in a given context, and instead opts to always write out any relevant impl's for a trait. Thus, blanket impls should be disabled when building with `#[cfg(c_bindings)]`.
The bindings generator is pretty naive in its generic resolution and doesn't like `where` clauses for bounds that are simple traits. This should eventually change, but for now its simplest to just inline the relevant generic bounds.
The "helpful" type aliases don't make sense for C bindings as all generics are concretized anyway.
I'm not sure why rustc didn't complain about the unused parameter or why we're allowed to get away without explicitly bounding the `Sign` in the `KeysInterface`, but the current code requires all `BlindedPath` construction to explicitly turbofish an unused type.
TheBlueMatt
force-pushed
the
2022-09-111-bindings-discovered-cleanups
branch
from
53aeeeb to
be7107f
Compare
|
Tweaked one more doc comment as suggested and squashed fixups. |
dunxen
previously approved these changes
Sep 12, 2022
|
When updating the sample, I found out that the |
|
Done. |
tnull
previously approved these changes
Sep 12, 2022
|
Ugh, sorry, was missing an |
TheBlueMatt
force-pushed
the
2022-09-111-bindings-discovered-cleanups
branch
from
105809e to
0c6040d
Compare
Note that `SimpleArcPeerHandler` is also updated to not wrap `IgnoringMessageHandler` in an `Arc`, as `IgnoringMessageHandler` is already zero-sized.
TheBlueMatt
force-pushed
the
2022-09-111-bindings-discovered-cleanups
branch
from
0c6040d to
b78359a
Compare
tnull
approved these changes
Sep 12, 2022
dunxen
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Really only the first is a practical change for Rust users, the others are just here because otherwise they'd be on the 0.0.111-bindings branch by themselves.