Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive Debug for AccessError #1709

Merged

Conversation

tnull
Copy link
Contributor

@tnull tnull commented Sep 9, 2022

Just a tiny change that makes error handling a little bit easier downstream.

@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2022

Codecov Report

Merging #1709 (689ac25) into main (301efc8) will increase coverage by 0.48%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1709      +/-   ##
==========================================
+ Coverage   90.92%   91.40%   +0.48%     
==========================================
  Files          86       86              
  Lines       46417    50928    +4511     
  Branches    46417    50928    +4511     
==========================================
+ Hits        42204    46553    +4349     
- Misses       4213     4375     +162     
Impacted Files Coverage Δ
lightning/src/chain/mod.rs 68.18% <100.00%> (ø)
lightning/src/util/events.rs 36.49% <0.00%> (-3.01%) ⬇️
lightning/src/chain/onchaintx.rs 94.71% <0.00%> (-0.23%) ⬇️
lightning/src/ln/monitor_tests.rs 99.44% <0.00%> (-0.12%) ⬇️
lightning/src/ln/payment_tests.rs 98.82% <0.00%> (-0.08%) ⬇️
lightning/src/ln/functional_tests.rs 97.88% <0.00%> (+0.77%) ⬆️
lightning/src/ln/msgs.rs 87.34% <0.00%> (+1.10%) ⬆️
lightning/src/util/test_utils.rs 79.92% <0.00%> (+2.42%) ⬆️
lightning-net-tokio/src/lib.rs 80.11% <0.00%> (+2.74%) ⬆️
lightning/src/ln/functional_test_utils.rs 96.36% <0.00%> (+2.77%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@TheBlueMatt TheBlueMatt merged commit 3a3c931 into lightningdevkit:main Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants