Correct payment resolution after on chain failure of dust HTLCs #1691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1691 +/- ##
==========================================
- Coverage 90.88% 90.78% -0.11%
==========================================
Files 85 85
Lines 46220 47408 +1188
Branches 46220 47408 +1188
==========================================
+ Hits 42007 43038 +1031
- Misses 4213 4370 +157
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
wpaulino
reviewed
Sep 6, 2022
There was a problem hiding this comment.
LGTM. There are a few warnings/failures to fix after the latest push.
Also wrote a commit to create a type alias for the test ChannelManager if you want to include it here, see https://gist.github.com/wpaulino/edc59a12b749452d8bcce2bb0816cee2.
TheBlueMatt
force-pushed
the
2022-08-dust-retry
branch
from
118f418 to
b0a0955
Compare
|
Oops lol I guess there was a reason the channel was being opened 0conf in the test. |
|
Feel free to squash. |
Previously, we wouldn't mark a dust HTLC as permanently resolved if the commitment transaction went on chain. This resulted in us always considering the HTLC as pending on restart, when we load the pending payments set from the monitors. Fixes lightningdevkit#1653.
|
Squashed without further changes. |
TheBlueMatt
force-pushed
the
2022-08-dust-retry
branch
from
b0a0955 to
a795e45
Compare
wpaulino
approved these changes
Sep 6, 2022
valentinewallace
approved these changes
Sep 7, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we wouldn't mark a dust HTLC as permanently resolved if
the commitment transaction went on chain. This resulted in us
always considering the HTLC as pending on restart, when we load the
pending payments set from the monitors.
Fixes #1653.