Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump bitcoin_hashes to v0.11 #1677

Merged
merged 1 commit into from
Aug 19, 2022
Merged

Bump bitcoin_hashes to v0.11 #1677

merged 1 commit into from
Aug 19, 2022

Conversation

ok300
Copy link
Contributor

@ok300 ok300 commented Aug 19, 2022

No description provided.

@TheBlueMatt
Copy link
Collaborator

Sadly, the version of bitcoin-hashes we depend on must match the version of rust-bitcoin we depend on. Thus, we can only do this when rust-bitcoin updated to the current version of bitcoin_hashes and we bump both at the same time.

@ok300
Copy link
Contributor Author

ok300 commented Aug 19, 2022

Should I bump both then?

This project is now using rust-bitcoin:0.29.0

They recently yanked1 0.29.0 and released 0.29.1 where they use bitcoin_hashes:0.11:

https://github.com/rust-bitcoin/rust-bitcoin/blob/deb867e33d30873c44c1d0c9917630ed52388d59/Cargo.toml#L37

So should I open a separate PR and bump both (btcoin_hashes -> 0.11, rust-bitcoin -> 0.29.1) ?

No problem if you'd say rather not, I already did it in my fork and figured I'd try upstream as well.

Footnotes

  1. https://docs.rs/bitcoin/0.29.0/bitcoin/index.html

@TheBlueMatt
Copy link
Collaborator

Gah, I'm sorry, I totally missed that this actually does match rust-bitcoin (and was confused by a spurious CI failure when I looked). I think this PR should be landable as-is, thanks for following up.

@TheBlueMatt TheBlueMatt reopened this Aug 19, 2022
@TheBlueMatt
Copy link
Collaborator

Note that depending on rust-bitcoin "0.29.0", in cargo parlance, actually depends on the latest rust-bitcoin 0.29.X

@ok300
Copy link
Contributor Author

ok300 commented Aug 19, 2022

Awesome!

Let me know if it needs any changes because of the (still?) failing builds.

@TheBlueMatt TheBlueMatt merged commit ea5b62f into lightningdevkit:main Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants