Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename UserConfig and LegacyChannelConfig fields #1540

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

wpaulino
Copy link
Contributor

The current names aren't very clear to what each field represents, this commit aims to improve that.

Follow-up from #1529.

The current names aren't very clear to what each field represents, this
commit aims to improve that.
@wpaulino wpaulino force-pushed the rename-config-fields branch from 9f18026 to 44fa3ac Compare June 13, 2022 20:57
@codecov-commenter
Copy link

Codecov Report

Merging #1540 (9f18026) into main (4356809) will increase coverage by 0.02%.
The diff coverage is 92.46%.

❗ Current head 9f18026 differs from pull request most recent head 44fa3ac. Consider uploading reports for the commit 44fa3ac to get more accurate results

@@            Coverage Diff             @@
##             main    #1540      +/-   ##
==========================================
+ Coverage   90.94%   90.96%   +0.02%     
==========================================
  Files          80       80              
  Lines       43533    43533              
  Branches    43533    43533              
==========================================
+ Hits        39589    39599      +10     
+ Misses       3944     3934      -10     
Impacted Files Coverage Δ
lightning/src/util/config.rs 61.62% <69.23%> (ø)
lightning/src/ln/channel.rs 88.58% <85.71%> (ø)
lightning-invoice/src/utils.rs 96.63% <100.00%> (ø)
lightning/src/ln/chanmon_update_fail_tests.rs 97.71% <100.00%> (ø)
lightning/src/ln/channelmanager.rs 84.34% <100.00%> (ø)
lightning/src/ln/functional_test_utils.rs 95.23% <100.00%> (ø)
lightning/src/ln/functional_tests.rs 97.16% <100.00%> (+0.10%) ⬆️
lightning/src/ln/onion_route_tests.rs 97.51% <100.00%> (ø)
lightning/src/ln/payment_tests.rs 99.24% <100.00%> (ø)
lightning/src/ln/priv_short_conf_tests.rs 96.60% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4356809...44fa3ac. Read the comment docs.

Copy link
Contributor

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you very much!

@TheBlueMatt TheBlueMatt merged commit 8fce6a1 into lightningdevkit:main Jun 14, 2022
@wpaulino wpaulino deleted the rename-config-fields branch June 14, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants