Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove previously deprecated Scorer #1512

Merged

Conversation

tnull
Copy link
Contributor

@tnull tnull commented Jun 1, 2022

This PR simply removes the old Scorer and related primitives that were previously deprecated since version 0.0.105.

@codecov-commenter
Copy link

Codecov Report

Merging #1512 (84c94a8) into main (f84ce03) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1512      +/-   ##
==========================================
+ Coverage   90.96%   90.98%   +0.01%     
==========================================
  Files          80       80              
  Lines       43409    43166     -243     
  Branches    43409    43166     -243     
==========================================
- Hits        39488    39275     -213     
+ Misses       3921     3891      -30     
Impacted Files Coverage Δ
lightning/src/routing/router.rs 92.45% <ø> (ø)
lightning/src/routing/scoring.rs 97.08% <ø> (+0.44%) ⬆️
lightning/src/ln/functional_tests.rs 97.16% <0.00%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f84ce03...84c94a8. Read the comment docs.

@TheBlueMatt TheBlueMatt added this to the 0.0.107 milestone Jun 1, 2022
@jkczyz jkczyz merged commit a3ad88a into lightningdevkit:main Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants