Reject outbound channels if the total reserve is larger than funding #1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 2826af7 we fixed a fuzz crash in which the total reserve values in a channel were greater than the funding amount, checked when an incoming channel is accepted. This, however, did not fix the same issue for outbound channels, where a peer can accept a channel with a nonsense reserve value in the `accept_channel` message. The `full_stack_target` fuzzer eventually found its way into the same issue, which this resolves. Thanks (again) to Chaincode Labs for providing the fuzzing resources which found this bug!
|
Would some docs like in L814 need to be changed to make clear the even lower upper bound for the reserve? |
I think the issue here is more that the fuzzer is opening channels with the full value of the channel as reserve, or close to it, less that our reserve value is higher than it should be. |
jkczyz
approved these changes
May 4, 2022
valentinewallace
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 2826af7 we fixed a fuzz crash
in which the total reserve values in a channel were greater than
the funding amount, checked when an incoming channel is accepted.
This, however, did not fix the same issue for outbound channels,
where a peer can accept a channel with a nonsense reserve value in
the
accept_channelmessage. Thefull_stack_targetfuzzereventually found its way into the same issue, which this resolves.
Thanks (again) to Chaincode Labs for providing the fuzzing
resources which found this bug!