Skip channel_update signature checks if we have a newer state
#1380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkczyz
reviewed
Mar 23, 2022
Codecov Report
@@ Coverage Diff @@
## main #1380 +/- ##
==========================================
+ Coverage 90.81% 90.94% +0.13%
==========================================
Files 73 73
Lines 41187 42311 +1124
Branches 41187 42311 +1124
==========================================
+ Hits 37402 38480 +1078
- Misses 3785 3831 +46
Continue to review full report at Codecov.
|
TheBlueMatt
force-pushed
the
2022-03-skip-redundant-sig-checks
branch
from
9a1e989 to
7819cbd
Compare
jkczyz
reviewed
Mar 24, 2022
jkczyz
previously approved these changes
Mar 24, 2022
`channel_update` messages already have their signatures checked with the network graph write lock held, so there's no reason to check the signatures before doing other quicker checks first, including checking if we're already aware of a newer update for the channel. This reduces common-case CPU usage as `channel_update`s are sent rather liberally over the p2p network to gossip them.
TheBlueMatt
force-pushed
the
2022-03-skip-redundant-sig-checks
branch
from
15a036a to
63ca72e
Compare
|
Squashed without changes. |
valentinewallace
approved these changes
Mar 24, 2022
jkczyz
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
channel_updatemessages already have their signatures checkedwith the network graph write lock held, so there's no reason to
check the signatures before doing other quicker checks first,
including checking if we're already aware of a newer update for the
channel.
This reduces common-case CPU usage as
channel_updates are sentrather liberally over the p2p network to gossip them.