Send a gossip_timestamp_filter on connect to enable gossip sync #1368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Its somewhat strange to have a trait method which is named after the intended action, rather than the action that occurred, leaving it up to the implementor what action they want to take.
On connection, if our peer supports gossip queries, and we never send a `gossip_timestamp_filter`, our peer is supposed to never send us gossip outside of explicit queries. Thus, we'll end up always having stale gossip information after the first few connections we make to peers. The solution is to send a dummy `gossip_timestamp_filter` immediately after connecting to peers.
TheBlueMatt
force-pushed
the
2022-03-fix-post-start-sync
branch
from
28feb19 to
3cca221
Compare
Codecov Report
@@ Coverage Diff @@
## main #1368 +/- ##
==========================================
- Coverage 90.73% 90.71% -0.02%
==========================================
Files 73 73
Lines 40808 40824 +16
Branches 40808 40824 +16
==========================================
+ Hits 37027 37035 +8
- Misses 3781 3789 +8
Continue to review full report at Codecov.
|
|
Looks good. Did we check that this fixes the issue? |
jkczyz
approved these changes
Mar 18, 2022
|
Kicked CI - it said "failed" but didn't have logs at all so I assume GitHub Actions is just acting up like usual. |
No idea, I didn't bother to reproduce the issue, but the spec seems to be pretty clear that this is required. It's possible we have other issues as well, though. |
valentinewallace
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On connection, if our peer supports gossip queries, and we never
send a
gossip_timestamp_filter, our peer is supposed to neversend us gossip outside of explicit queries. Thus, we'll end up
always having stale gossip information after the first few
connections we make to peers.
The solution is to send a dummy
gossip_timestamp_filterimmediately after connecting to peers.