Generate a funding_locked on relevant transactions_confirmed calls #1363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1363 +/- ##
=======================================
Coverage 90.65% 90.66%
=======================================
Files 73 73
Lines 40462 40482 +20
=======================================
+ Hits 36682 36701 +19
- Misses 3780 3781 +1
Continue to review full report at Codecov.
|
TheBlueMatt
force-pushed
the
2022-03-tx-conf-ordering-lock-delay
branch
from
4e89d79 to
5d82303
Compare
jkczyz
previously approved these changes
Mar 14, 2022
jkczyz
reviewed
Mar 14, 2022
TheBlueMatt
force-pushed
the
2022-03-tx-conf-ordering-lock-delay
branch
from
5d82303 to
abfc3ec
Compare
jkczyz
previously approved these changes
Mar 14, 2022
Previously, if we were offline when a funding transaction was locked in, and then we came back online, calling `best_block_updated` once followed by `transactions_confirmed`, we'd not generate a funding_locked until the next `best_block_updated`. We address this by re-calling `best_block_updated` in `transactions_confirmed`, similar to how `ChannelMonitor` works.
TheBlueMatt
force-pushed
the
2022-03-tx-conf-ordering-lock-delay
branch
from
abfc3ec to
ea76942
Compare
|
Squashed without changes. |
jkczyz
approved these changes
Mar 16, 2022
valentinewallace
approved these changes
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if we were offline when a funding transaction was
locked in, and then we came back online, calling
best_block_updatedonce followed bytransactions_confirmed,we'd not generate a funding_locked until the next
best_block_updated.We address this by re-calling
best_block_updatedintransactions_confirmed, similar to howChannelMonitorworks.Reported by BlueWallet.