Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct docs about invoice_expiry_delta_secs panic #1341

Merged

Conversation

jkczyz
Copy link
Contributor

@jkczyz jkczyz commented Mar 2, 2022

The panic for invoice_expiry_delta_secs is only applicable for create_inbound_payment_legacy.

@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2022

Codecov Report

Merging #1341 (f334205) into main (6259e7a) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head f334205 differs from pull request most recent head f1a6469. Consider uploading reports for the commit f1a6469 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1341      +/-   ##
==========================================
- Coverage   90.60%   90.59%   -0.01%     
==========================================
  Files          72       72              
  Lines       40075    40075              
==========================================
- Hits        36310    36306       -4     
- Misses       3765     3769       +4     
Impacted Files Coverage Δ
lightning/src/ln/channelmanager.rs 84.69% <ø> (ø)
lightning/src/ln/functional_tests.rs 97.06% <0.00%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6259e7a...f1a6469. Read the comment docs.

@TheBlueMatt
Copy link
Collaborator

Shouldn't we add a similar note on create_inbound_payment_for_hash_legacy?

@jkczyz jkczyz added this to the 0.0.106 milestone Mar 7, 2022
@jkczyz
Copy link
Contributor Author

jkczyz commented Mar 9, 2022

Shouldn't we add a similar note on create_inbound_payment_for_hash_legacy?

Ah, yes. Done.

@valentinewallace valentinewallace merged commit 756bcbc into lightningdevkit:main Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants