Persist ChannelManager before BackgroundProcessor exits
#1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinewallace
previously approved these changes
Jan 18, 2022
TheBlueMatt
force-pushed
the
2022-01-background-persist-exit
branch
from
4a1f87c to
ce82a33
Compare
Codecov Report
@@ Coverage Diff @@
## main #1253 +/- ##
==========================================
+ Coverage 90.41% 90.42% +0.01%
==========================================
Files 70 70
Lines 38087 38087
==========================================
+ Hits 34437 34441 +4
+ Misses 3650 3646 -4
Continue to review full report at Codecov.
|
jkczyz
approved these changes
Jan 24, 2022
valentinewallace
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1237.