-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dummy sync implementation for no_std #1008
Dummy sync implementation for no_std #1008
Conversation
in preparation for no-std sync dummies
Codecov Report
@@ Coverage Diff @@
## main #1008 +/- ##
==========================================
- Coverage 90.76% 90.76% -0.01%
==========================================
Files 60 60
Lines 30909 30909
==========================================
- Hits 28056 28055 -1
- Misses 2853 2854 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Glad it kinda just worked. CI should also at least run cargo test --no-default-features --features no_std
(it currently just runs with hashbrown
explicitly), but that seems to pass locally.
I read what you said as "instead of |
c559621
to
78346f3
Compare
7e6557d
to
50f4847
Compare
50f4847
to
2e8f4fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 2e8f4fe
We would like to not bother synchronizing access on no_std platforms, because there is no mature rust multi-threading support for them yet. Accordingly, this PR implements drop-in replacements for
Mutex
,Condvar
and (not done yet)RwLock
.See also discussion in #842 (comment) - but this PR uses a slightly different approach.