This repository was archived by the owner on Jan 6, 2025. It is now read-only.
Make crate no_std compatible
#53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnull
force-pushed
the
2023-11-no-std
branch
from
f83051e to
6be3e3f
Compare
tnull
force-pushed
the
2023-11-no-std
branch
4 times, most recently
from
089bb91 to
ac1a539
Compare
tnull
force-pushed
the
2023-11-no-std
branch
from
ac1a539 to
679f366
Compare
This was referenced Nov 29, 2023
Closed
Copying the pattern from the `lightning` crate, we re-export `alloc`/`hashbrown` or `std` depending on whether the `std` feature is set. We also copy some `sync` types from the `lightning` crate that are `no-std` compatible. Moreover, we check no-std compatibility in CI and, since we already touched most of them, reorder and cleanup the `use` statements in all modules.
johncantrell97
approved these changes
Dec 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29.
Copying the pattern from the
lightningcrate, we re-exportalloc/hashbrownorstddepending on whether thestdfeature is set. We also copy somesynctypes from thelightningcrate that areno-stdcompatible.Moreover, we check no-std compatibility in CI and, since we already touched most of them, reorder and cleanup the
usestatements in all modules.One thing we don't tackle in this PR is validating the expiry times of
OpeningFeeParamsinno-std. This is now tracked separately in lightningdevkit/rust-lightning#3471.