2760 #27
2760 #27
Conversation
✅ Deploy Preview for courageous-frangipane-fab648 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Thanks, @jbesraa! Looking good so far. Did you want a little more time to flesh out the other questions on V2 establishment or do you need some assistance? I think we don't really need to focus on V1 vs V2 stuff here and rather dig deeper into the cause of the bug! :D |
Yea no problem. Are we planning to run this tomorrow? |
_posts/2023-12-06-#2760.md
Outdated
|
|
||
| +-------+ +-------+ | ||
| | |--(1)- open_channel ---->| | | ||
| | |<-(2)- accep_channel ----| | |
There was a problem hiding this comment.
| | |<-(2)- accep_channel ----| | | |
| | |<-(2)- accept_channel ----| | |
_posts/2023-12-06-#2760.md
Outdated
| ## Notes | ||
| Creating a channel involves exchanging multiple messages with a | ||
| connected peer, which does not always end up successfully. | ||
| Specificly, in the current implemntation an infinite loop might occur |
There was a problem hiding this comment.
| Specificly, in the current implemntation an infinite loop might occur | |
| Specifically, in the current implementation an infinite loop might occur |
_posts/2023-12-06-#2760.md
Outdated
| Creating a channel involves exchanging multiple messages with a | ||
| connected peer, which does not always end up successfully. | ||
| Specificly, in the current implemntation an infinite loop might occur | ||
| in the funding step. |
There was a problem hiding this comment.
I think we should mention that this bug resulted from lightningdevkit/rust-lightning#2077 specifically.
_posts/2023-12-06-#2760.md
Outdated
| 1. Did you review the PR? [Concept ACK, approach ACK, tested ACK, or NACK](https://github.com/lightningdevkit/rust-lightning/blob/master/CONTRIBUTING.md#peer-review)? | ||
| 2. In the original code we have a loop inside `close_channel_internal`, | ||
| in which scenario it goes indefintly? | ||
| 3. why are we able to drop `force_close_channel_with_peer` from |
There was a problem hiding this comment.
| 3. why are we able to drop `force_close_channel_with_peer` from | |
| 3. Why are we able to drop `force_close_channel_with_peer` from |
_posts/2023-12-06-#2760.md
Outdated
| 4. question about v2 channel establishemnt | ||
| 5. question about v2 channel establishemnt |
There was a problem hiding this comment.
| 4. question about v2 channel establishemnt | |
| 5. question about v2 channel establishemnt | |
| 4. What was the reasoning for promoting an `OutboundV1Channel` to a `Channel` before receiving `funding_signed` prior to this PR? Why do we no only do that promotion after receiving `funding_signed`? |
_posts/2023-12-06-#2760.md
Outdated
| @@ -0,0 +1,46 @@ | |||
| --- | |||
| layout: pr | |||
| date: 2023-00-00 | |||
There was a problem hiding this comment.
We still need a valid date here otherwise it won't compile :)
|
LGTM if you're happy! I'll merge and then we can still make adjustments if needed. At least we can make the announcement today. |
@dunxen
review club for lightningdevkit/rust-lightning#2760