-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ClayAlert with action button #2765
Comments
Hi Sarai!
At least it should be in Clay v3. Duurii documented it on LEXI-509 cc\ @bryceosterhaus |
@pat270 do we need any special markup to reach this result? |
I was able to create the layout with react components, you may need to add some custom styles for the button color. https://codesandbox.io/s/clay2765-s039q |
A few months ago, I created an example using The problem was the background and the solutions we found were:
The problem with 1st solution is the duplicated code we need to create to use this variation more than once There is a 4th solution we should explore, changing the default outlined versions of buttons in Atlas and the current usages of these buttons but it doesn't seem an easy task |
@matuzalemsteles I remember from a while ago @victorvalle saying this doesn't need to be handled in Clay CSS. I'm not 100% sure, I can't seem to find anything on it. We can add button variants in alerts if we need. The selector will probably be |
I don't remember what I said :(. For the moment these button variants are only needed in alerts. |
Hmm, we will probably need some extra markup to align the button with the text and add extra spacing... |
@matuzalemsteles that is probably the case. |
Lima-team is asking for this component in Alerts. Check LEXI-509 Any update on the progress of this ticket? |
…row` and `.autofit-col` spacing issue liferay#2765
…t-footer`, and `.alert .btn-group-item` feat(clay-css): Alert adds Sass maps `$alert-btn`, `$alert-btn-group-item`, `$alert-footer`, `$alert-autofit-row`, `$alert-primary-btn`, `$alert-secondary-btn`, `$alert-success-btn`, `$alert-info-btn`, `$alert-warning-btn`, `$alert-danger-btn`, `$alert-light-btn`, `$alert-dark-btn` fixes liferay#2765
…row` and `.autofit-col` spacing issue liferay#2765
…t-footer`, and `.alert .btn-group-item` feat(clay-css): Alert adds Sass maps `$alert-btn`, `$alert-btn-group-item`, `$alert-footer`, `$alert-autofit-row`, `$alert-primary-btn`, `$alert-secondary-btn`, `$alert-success-btn`, `$alert-info-btn`, `$alert-warning-btn`, `$alert-danger-btn`, `$alert-light-btn`, `$alert-dark-btn` fixes liferay#2765
@matuzalemsteles I sent a pr with this pattern. The markup should look something like:
|
…row` and `.autofit-col` spacing issue #2765
…t-footer`, and `.alert .btn-group-item` feat(clay-css): Alert adds Sass maps `$alert-btn`, `$alert-btn-group-item`, `$alert-footer`, `$alert-autofit-row`, `$alert-primary-btn`, `$alert-secondary-btn`, `$alert-success-btn`, `$alert-info-btn`, `$alert-warning-btn`, `$alert-danger-btn`, `$alert-light-btn`, `$alert-dark-btn` fixes #2765
…row` and `.autofit-col` spacing issue liferay#2765
…t-footer`, and `.alert .btn-group-item` feat(clay-css): Alert adds Sass maps `$alert-btn`, `$alert-btn-group-item`, `$alert-footer`, `$alert-autofit-row`, `$alert-primary-btn`, `$alert-secondary-btn`, `$alert-success-btn`, `$alert-info-btn`, `$alert-warning-btn`, `$alert-danger-btn`, `$alert-light-btn`, `$alert-dark-btn` fixes liferay#2765
I have an use case to use an Alert with an action in the A/B Testing sidebar when a test has a winner variant. I found this patter in Lexicon https://liferay.design/lexicon/core-components/alerts/ but not in Clay.
What is your question?
Is this supported in ClayAlert?
/cc @drakonux @laugardie
The text was updated successfully, but these errors were encountered: