Skip to content

Commit

Permalink
fix(@clayui/css): Mixins clay-link and clay-close Removes the `.s…
Browse files Browse the repository at this point in the history
…how > &` selector

It doesn't work well with deeply nested selectors. It generates irrelevant selectors like `.show > .nav-tabs .nav-link`.
  • Loading branch information
pat270 committed Dec 2, 2021
1 parent 73227a0 commit 9b523cf
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
1 change: 0 additions & 1 deletion packages/clay-css/src/scss/mixins/_close.scss
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,6 @@
@include clay-css($active);
}

.show > &,
&.active {
@include clay-css($active-class);
}
Expand Down
3 changes: 1 addition & 2 deletions packages/clay-css/src/scss/mixins/_links.scss
Original file line number Diff line number Diff line change
Expand Up @@ -757,8 +757,7 @@
}

&[aria-expanded='true'],
&.show,
.show > & {
&.show {
@include clay-css($show);

&::before {
Expand Down

0 comments on commit 9b523cf

Please sign in to comment.