Add Prettier #957
Merged
Add Prettier #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wincent
commented
Jan 17, 2019
wincent
commented
Jan 17, 2019
For now, just a simple manual invocation (`npm run format`) to fix things up (`npm run prettier` also offered as a synonym, and `npm run checkFormat` to report files which aren't curretly formatted). The package.json tasks match the names that we're using for the same in Clay. Note the `.prettierignore` file in "src/lang" to prevent the generated files from being needlessly formatted. (Although the truth is, we could format them too if we wanted.) Once we're happy with this we can look at enforcing correct formatting with the linter in CI. Closes: https://issues.liferay.com/browse/IFI-411
|
OK, so I refreshed this on top of the current |
julien
approved these changes
Jan 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should merge something like this when things have settled down a bit and some of the currently in-flight PRs have landed, but this is a preview of how things could look.
As noted in the commit message, this is manual for now (
npm run pretty): if we like it, we can enforce formatting with then linter and in the CI.Related: https://issues.liferay.com/browse/IFI-411