Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change dragresize implementation on IE to modify heigh and width insi… #923

Merged
merged 1 commit into from
Nov 26, 2018

Conversation

gregory-bretall
Copy link
Contributor

…de the style attribute so as to be consistent with the standard AlloyEditor resizing behavior.

Prelude

Default dragresize implementation doesn't work in IE11, so the CKEditor behavior was copied over without changes.

Issue

#901

The issue is a mismatch in how dragresize modifies height/width for an image between IE and other browsers. In most browsers, we modify height and width inside the image's style attribute. However, IE's implementation of dragresize copies directly from how CKEditor handles this which is to use individual height and width attributes for the image. The problem here is if both are present because the image was edited in different browsers then the edits from non-IE browsers will always take precedence.

Solution

I removed our use of the height/width attributes for dragresize_ie and replaced them with style modifications to line up with the behavior on other browsers.

Test

This fix has been tested on Internet Explorer 11, the main environment were we use dragresize_ie.

Resending this as a fixed PR from #920

…de the style attribute so as to be consistent with the standard AlloyEditor resizing behavior.
@julien
Copy link
Contributor

julien commented Nov 26, 2018

Just started reviewing :)

:octocat: Sent from GH.

@julien julien merged commit 7f87818 into liferay:develop Nov 26, 2018
@julien
Copy link
Contributor

julien commented Nov 26, 2018

@gregory-bretall Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants