Change dragresize implementation on IE to modify heigh and width insi… #923
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…de the style attribute so as to be consistent with the standard AlloyEditor resizing behavior.
Prelude
Default dragresize implementation doesn't work in IE11, so the CKEditor behavior was copied over without changes.
Issue
#901
The issue is a mismatch in how dragresize modifies height/width for an image between IE and other browsers. In most browsers, we modify height and width inside the image's style attribute. However, IE's implementation of dragresize copies directly from how CKEditor handles this which is to use individual height and width attributes for the image. The problem here is if both are present because the image was edited in different browsers then the edits from non-IE browsers will always take precedence.
Solution
I removed our use of the height/width attributes for dragresize_ie and replaced them with style modifications to line up with the behavior on other browsers.
Test
This fix has been tested on Internet Explorer 11, the main environment were we use dragresize_ie.
Resending this as a fixed PR from #920