Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #911 Use correct CSS to place drag resize handle at the corner #912

Merged
merged 1 commit into from
Nov 20, 2018

Conversation

brianikim
Copy link
Member

@brianikim brianikim commented Nov 16, 2018

Issue

#911
In IE11 when changing the image's alignment to the right the drag resize handle moves from it's expected lower righthand location to the lower lefthand side. However, the handle is misplaced slightly to the right of the lefthand corner.

Solution

The CSS property left for cke_image_resizer_left just has to be adjusted to be -25px isntead of -5px.

The issue only appears in IE11 and have tested also in Chrome, Firefox, and Edge. The issue is only reproducible on Liferay AlloyEditor.

Let me know if there are any questions or comments.
Thank you.

@brianikim
Copy link
Member Author

cc/ @jbalsas

@julien
Copy link
Contributor

julien commented Nov 20, 2018

Just started reviewing :)

:octocat: Sent from GH.

@julien julien merged commit aab69a8 into liferay:master Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants