Buttons that use richcombo update correctly values when it is rendered for the first time. #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d for the first time. Fixes liferay#548
|
With this fix, I am not sure if the name of the method cacheValue is correct because I use it into _setValue. |
|
Just started reviewing :) |
Sent from
|
Hey @antoniopol06, What exactly are you concerns? Are there any other options? Thanks, |
|
Shouldn't we be rendering based on the state and not on the cached value here? |
|
Or was that what we had to do to support #515? In that case, the setState is there just to force a re-render? |
|
Yes, that line of code was part of #515. |
|
Thank you, pull request merged! See changes here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.