Support style string definition (Fixes #533)

[jbalsas]

Hey @ipeychev, this is the improvement we discussed for #533.

Now, this will work out of the box:

[...]
AlloyEditor.editable('editable', {
    coreStyles_bold: customBoldStyle,
    coreStyles_italic: customItalicStyle,
    coreStyles_underline: customUnderlineStyle,
    coreStyles_strike: customStrikeStyle,
    coreStyles_subscript: customSubscriptStyle,
    coreStyles_superscript: customSuperscriptStyle
});

[jbalsas]

/cc @qasid

[ipeychev]

Just started reviewing :)

Sent from GH.

[ipeychev]

Hey Chema,

This sentence "a string pointing to an object inside the editor instance configuration" will need an example. We shall document this for 1.2.3 release and I'm not sure what exactly could be this string.

Could you please add an example to this comment?

Thanks,

[jbalsas]

Ok, I'll add an example tomorrow. You can see the usage in the buttons that are now configured with the string. For example,

style: 'coreStyles_bold'

will try to get the style from editor.config.coreStyles_bold and

style: 'myPlugin.myCustomObject.myCustomStyle'

will try to get it from editor.config.myPlugin.myCustomObject.myCustomStyle

Do you think that would be clear enough? If so, I'll push that tomorrow morning! :)

[ipeychev]

Yes, this will be enough and the whole change is great!

Thanks,

[jbalsas]

Pushed new commit with improved docs 😉

[ipeychev]

Just started reviewing :)

Sent from GH.

[ipeychev]

Thank you, pull request merged!

Sent from GH.